[GTK3] Do not crash in SetData event #1612
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basilevs
force-pushed
the
issue_678_setdata_fix
branch
from
e3d540c
to
d8ba369
Compare
Test Results 483 files ±0 483 suites ±0 9m 13s ⏱️ +35s For more details on these failures, see this check. Results for commit 09cfb68. ± Comparison against base commit 266cc26. ♻️ This comment has been updated with latest results. |
basilevs
force-pushed
the
issue_678_setdata_fix
branch
from
d8ba369
to
7e7c87c
Compare
|
Test failures are caused by #1564 |
basilevs
force-pushed
the
issue_678_setdata_fix
branch
2 times, most recently
from
7c58564
to
b1bf254
Compare
GTK 3.24.41 (Ubuntu 24) crashes when renderers are replaced during render. If replacement is postponed, the crash no longer happens. Fixes eclipse-platform#678.
basilevs
force-pushed
the
issue_678_setdata_fix
branch
from
b1bf254
to
09cfb68
Compare
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The crash happens when renderers are replaced during render. If replacement is postponed, the crash no longer happens. The failure only happens in Ubuntu 24 (GTK 3.24.41).
Fixes #678.
Is tested by #1611.